Define custom models in json rather than the database schema#1752
Merged
chrarnoldus merged 7 commits intomainfrom Mar 31, 2026
Merged
Define custom models in json rather than the database schema#1752chrarnoldus merged 7 commits intomainfrom
chrarnoldus merged 7 commits intomainfrom
Conversation
Migrate all queries and type references from the old custom_llm table to custom_llm2, which stores model configuration in a single JSON definition column. Add missing fields (provider, force_reasoning, interleaved_format) to CustomLlmDefinitionSchema and introduce parseCustomLlm2Row helper to parse the JSON definition.
…omLlm Query custom_llm2 (jsonb) and use definition fields directly instead of mapping to the old CustomLlm type. Remove parseCustomLlm2Row helper and revert additions of provider/force_reasoning/interleaved_format to CustomLlmDefinitionSchema. Leave grokCodeFastOptimizedRequest untouched.
chrarnoldus
changed the title
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
WARNING
Other Observations (not in diff)N/A Files Reviewed (5 files)
|
markijbema
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because database migrations are a pain