feat(promo): add new encrypted promo credit category#1734
Open
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Open
feat(promo): add new encrypted promo credit category#1734kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
Add a new self-service encrypted promo code entry for an upcoming event promotion. 0 credits, 1050 max redemptions, expires 2026-04-13.
src/lib/promoCreditCategories.ts
Outdated
| { | ||
| // TODO: Replace encrypted_credit_category with production-encrypted value. | ||
| // Run: vercel env run -e production -- pnpm promo encrypt CLAW_MIA | ||
| encrypted_credit_category: 'a1o0/So4YgGvB+ABnOOqAw==:qlVqBAHvDFjp4npGlFnwqg==:q+0OuXzZu6E=', |
Contributor
Author
There was a problem hiding this comment.
CRITICAL: Placeholder ciphertext will fail to decrypt in production
encryptedSelfServicePromos is decrypted at module load via decryptPromoCode(...). Because this value is marked as generated with a non-production key, decryptWithSymmetricKey will reject it under the production CREDIT_CATEGORIES_ENCRYPTION_KEY, and any import of promoCreditCategories.ts will throw before the promo list can be used. Replace this with ciphertext generated from the production key before merge.
Contributor
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)CRITICAL
Other Observations (not in diff)N/A Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 181,887 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new self-service encrypted promo credit category entry. The entry provides $50 credits with the following configuration:
Important: The
encrypted_credit_categoryfield is set toPLACEHOLDER. Before merging, generate the real value with:and replace the placeholder. The promo code to encrypt is referenced in the originating task.
Verification
pnpm typecheck— passed, no errorspnpm lint— passed (via pre-push hook)pnpm format:check— passed (via pre-push hook)Visual Changes
N/A
Reviewer Notes
The
encrypted_credit_categoryvalue must be replaced with a production-encrypted value before merging. The TODO comment in the source code indicates how to generate it.