fix(bot): stop stderr output from swallowing PR/MR URLs in bot responses #1709
+112
−4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Tests for run-session.ts | ||
| * | ||
| * Tests the pure helper functions (resolveStreamUrl, extractTextFromMessage) | ||
| * exported from run-session.ts. | ||
| */ | ||
|
|
||
| import { resolveStreamUrl, extractTextFromMessage } from './run-session'; | ||
| import type { ProcessedMessage } from './processor'; | ||
|
|
||
| // ─── resolveStreamUrl ─────────────────────────────────────────────── | ||
|
|
||
| describe('resolveStreamUrl', () => { | ||
| it('throws when streamUrl is empty', () => { | ||
| expect(() => resolveStreamUrl('')).toThrow('Cloud Agent stream URL is missing'); | ||
| }); | ||
|
|
||
| it('returns an absolute wss:// URL when given an absolute https:// URL', () => { | ||
| const result = resolveStreamUrl('https://agent.example.com/stream?id=123'); | ||
| expect(result).toBe('wss://agent.example.com/stream?id=123'); | ||
| }); | ||
|
|
||
| it('returns an absolute ws:// URL when given an absolute http:// URL', () => { | ||
| const result = resolveStreamUrl('http://agent.example.com/stream'); | ||
| expect(result).toBe('ws://agent.example.com/stream'); | ||
| }); | ||
|
|
||
| it('passes through an already-wss URL unchanged', () => { | ||
| const result = resolveStreamUrl('wss://agent.example.com/stream'); | ||
| expect(result).toBe('wss://agent.example.com/stream'); | ||
| }); | ||
| }); | ||
|
|
||
| // ─── extractTextFromMessage ───────────────────────────────────────── | ||
|
|
||
| function makeMessage(parts: ProcessedMessage['parts']): ProcessedMessage { | ||
| return { | ||
| info: { | ||
| id: 'msg-1', | ||
| sessionID: 'session-1', | ||
| role: 'assistant', | ||
| time: { created: Date.now() }, | ||
| }, | ||
| parts, | ||
| }; | ||
| } | ||
|
|
||
| describe('extractTextFromMessage', () => { | ||
| it('returns empty string when message has no parts', () => { | ||
| expect(extractTextFromMessage(makeMessage([]))).toBe(''); | ||
| }); | ||
|
|
||
| it('extracts text from a single text part', () => { | ||
| const message = makeMessage([ | ||
| { id: 'p1', sessionID: 's1', messageID: 'm1', type: 'text', text: 'PR opened at https://github.com/org/repo/pull/42' }, | ||
| ]); | ||
| expect(extractTextFromMessage(message)).toBe( | ||
| 'PR opened at https://github.com/org/repo/pull/42' | ||
| ); | ||
| }); | ||
|
|
||
| it('concatenates multiple text parts', () => { | ||
| const message = makeMessage([ | ||
| { id: 'p1', sessionID: 's1', messageID: 'm1', type: 'text', text: 'Changes applied. ' }, | ||
| { id: 'p2', sessionID: 's1', messageID: 'm1', type: 'text', text: 'PR: https://github.com/org/repo/pull/42' }, | ||
| ]); | ||
| expect(extractTextFromMessage(message)).toBe( | ||
| 'Changes applied. PR: https://github.com/org/repo/pull/42' | ||
| ); | ||
| }); | ||
|
|
||
| it('ignores non-text parts like tool parts', () => { | ||
| const message = makeMessage([ | ||
| { | ||
|
Check failure on line 74 in src/lib/cloud-agent-next/run-session.test.ts
|
||
| id: 'p1', | ||
| sessionID: 's1', | ||
| messageID: 'm1', | ||
| type: 'tool', | ||
| call: { id: 'call-1', name: 'bash', input: '{}' }, | ||
| } as ProcessedMessage['parts'][number], | ||
| { id: 'p2', sessionID: 's1', messageID: 'm1', type: 'text', text: 'Done!' }, | ||
| ]); | ||
| expect(extractTextFromMessage(message)).toBe('Done!'); | ||
| }); | ||
|
|
||
| it('trims whitespace from the final result', () => { | ||
| const message = makeMessage([ | ||
| { id: 'p1', sessionID: 's1', messageID: 'm1', type: 'text', text: ' Hello ' }, | ||
| ]); | ||
| expect(extractTextFromMessage(message)).toBe('Hello'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Non-zero agent exits still bypass this error path
This branch only runs when
hasErrorwas set earlier, but thecompletehandler never marks a non-zeroexitCodeas fatal. After changing stderr to only fliphasStderr, a session that exits with code1and only writes to stderr will now fall through to the success response, so users won't see that the run actually failed. Treatingcomplete.data.exitCode !== 0as an error would preserve the original failure signal while still allowingcompletionResultto be appended here.