layers: Handle GPL with DynamicRendering and InputAttachment - #12911
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 85876. |
|
CI Vulkan-ValidationLayers build # 24197 running. |
ziga-lunarg
left a comment
There was a problem hiding this comment.
Take the positive test and change input_attachment_index to 1. That should give you a negative test with VUID-VkGraphicsPipelineCreateInfo-renderPass-09652 since now input attachment index is not less than color attachment count. In my PR this works, in yours it doesn't
|
CI Vulkan-ValidationLayers build # 24197 passed. |
|
@ziga-lunarg good catch... the issue is the Fragment Shader library knows the InputAttachment index, but the Fragment Output knows the colorAttachmentCount this means we need to validate this at the final linking, will fix |
8dfee10 to
71fe71f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 86736. |
|
@ziga-lunarg I ended up going towards the route you did, but shifted it a bit as I realize the concept of InputAttachment is really a "Shader Interface" and not a "SPIR-V" check so moved the logic from |
|
CI Vulkan-ValidationLayers build # 24211 running. |
|
CI Vulkan-ValidationLayers build # 24211 failed. |
simpler version of #12908