Skip to content

layers: Handle GPL with DynamicRendering and InputAttachment - #12911

Open
spencer-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world
Open

layers: Handle GPL with DynamicRendering and InputAttachment#12911
spencer-lunarg wants to merge 1 commit into
KhronosGroup:mainfrom
spencer-lunarg:spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world

Conversation

@spencer-lunarg

Copy link
Copy Markdown
Contributor

simpler version of #12908

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 85876.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24197 running.

@ziga-lunarg ziga-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the positive test and change input_attachment_index to 1. That should give you a negative test with VUID-VkGraphicsPipelineCreateInfo-renderPass-09652 since now input attachment index is not less than color attachment count. In my PR this works, in yours it doesn't

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24197 passed.

@spencer-lunarg

Copy link
Copy Markdown
Contributor Author

@ziga-lunarg good catch... the issue is the Fragment Shader library knows the InputAttachment index, but the Fragment Output knows the colorAttachmentCount

this means we need to validate this at the final linking, will fix

@spencer-lunarg
spencer-lunarg force-pushed the spencer-lunarg-i-think-gpl-could-be-a-good-extension-if-you-first-deleted-it-from-the-world branch from 8dfee10 to 71fe71f Compare August 22, 2026 00:16
@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 86736.

@spencer-lunarg

Copy link
Copy Markdown
Contributor Author

@ziga-lunarg I ended up going towards the route you did, but shifted it a bit as I realize the concept of InputAttachment is really a "Shader Interface" and not a "SPIR-V" check so moved the logic from cc_spirv.cpp to cc_shader_interface.cpp

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24211 running.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

CI Vulkan-ValidationLayers build # 24211 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants