Conversation
tobine
requested review from
TonyBarbour,
chrisforbes,
daveh-lunarg,
jzulauf-lunarg,
mark-lunarg and
mikes-lunarg
|
This all seems copacetic, once the status board is all green. |
|
The fails are because DevSim doesn't yet report the extended properties or features. |
|
Extension support is currently being added to DevSim, so this is good timing for the feature request. |
jzulauf-lunarg
left a comment
jzulauf-lunarg
left a comment
There was a problem hiding this comment.
You still have one missing query (VkPhysicalDeviceIDPropertiesKHR) pNext type missing that doesn't correspond to a blacklisted extension
| cr_prop->conservativeRasterizationPostDepthCoverage = VK_FALSE; | ||
| break; | ||
| } | ||
| default: |
There was a problem hiding this comment.
VkPhysicalDeviceIDPropertiesKHR is missing from the list but not on the "naughty" list below.
tobine
force-pushed
the
tobin_gh2374_mock_query
branch
2 times, most recently
from
881a4fc to
f4c96c0
Compare
|
Great catch, @jzulauf-lunarg. The exclusion was un-intentional and I've pushed an update to add the missing extension. |
Updated vkGetPhysicalDeviceProperties2KHR() implementation in the mock ICD to handle extension queries down pNext tree. This is for #2374. Note that the bug references vkGetPhysicalDeviceFeatures2KHR() which will be done in a separate CL.
Fixes #2374 Updated vkGetPhysicalDeviceFeatures2KHR() implementation in the mock ICD to handle extension feature queries down pNext tree. Initially returning all extension features as supported by mock icd.
tobine
force-pushed
the
tobin_gh2374_mock_query
branch
from
f4c96c0 to
779a3ae
Compare
|
@tobine, this repository will close for write access on Sunday, 5/13/2018. If it is pushed before that time it will be present in the follow-on Vulkan-ValidationLayers repository on Monday, otherwise a new PR will be required in the new repo. |
4 participants
Updated mock icd to handle extension feature and properties queries down the GPDP2 and GPDF2 paths.