Only log after determining global stderr_log filters#1653
Open
charles-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Only log after determining global stderr_log filters#1653charles-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
charles-lunarg wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
|
CI Vulkan-Loader build queued with queue ID 364839. |
|
CI Vulkan-Loader build queued with queue ID 364856. |
|
CI Vulkan-Loader build # 2905 running. |
|
CI Vulkan-Loader build # 2905 failed. |
This change prevents the loader from logging anything before determining if the loader settings file has stderr_log filters that should take precedence. Without the change, info about the loader version, branch, and the settings file itself could be printed depending on the value of VK_LOADER_DEBUG.
charles-lunarg
force-pushed
the
update_global_settings_in_initialization
branch
from
6110fe1 to
3092599
Compare
|
CI Vulkan-Loader build queued with queue ID 365012. |
|
CI Vulkan-Loader build queued with queue ID 365029. |
|
CI Vulkan-Loader build # 2907 running. |
|
CI Vulkan-Loader build # 2907 failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the loader from logging anything before determining if the loader settings file has stderr_log filters that should take precedence. Without the change, info about the loader version, branch, and the settings file itself could be printed depending on the value of VK_LOADER_DEBUG.