Use khiops-core and khiops-driver-* pip packages containing binaries only by tramora · Pull Request #582 · KhiopsML/khiops-python

tramora · 2026-05-26T16:22:12Z

TODO Before Asking for a Review

Rebase your branch to the latest version of main (or main-v10)
Make sure all CI workflows are green
When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
Self-Review: Review "Files Changed" tab and fix any problems you find
API Docs (only if there are changes in docstrings, rst files or samples):
- Check the docs build without warning: see the log of the API Docs workflow
- Check that your changes render well in HTML: download the API Docs artifact and open index.html
- If there are any problems it is faster to iterate by building locally the API Docs

tramora · 2026-05-28T23:51:33Z

False sentiment of success : we simulate multiple Python environments using conda (#573). This is very unfortunate as we are not able yet to detect automatically an issue with the new PyPI packages regarding the remote drivers khiops-core:1041. In my opinion this one is a blocking issue.

popescu-v · 2026-05-29T09:37:34Z

False sentiment of success : we simulate multiple Python environments using conda (#573). This is very unfortunate as we are not able yet to detect automatically an issue with the new PyPI packages regarding the remote drivers khiops-core:1041. In my opinion this one is a blocking issue.

Hence, to properly test this, issue #573 must be addressed first. Right, @tramora ?

tramora · 2026-05-29T10:30:36Z

False sentiment of success : we simulate multiple Python environments using conda (#573). This is very unfortunate as we are not able yet to detect automatically an issue with the new PyPI packages regarding the remote drivers khiops-core:1041. In my opinion this one is a blocking issue.

Hence, to properly test this, issue #573 must be addressed first. Right, @tramora ?

I changed the $CONDA install -y -n env ... to $CONDA run -n env pip install ... in order to really use the PyPI packages.
But it is not perfect yet as the run will set the CONDA_PREFIX environment variable that is checked by khiops-python to determine if the installation is done in a 'conda' method or not. 'conda' method and 'pip' one are close but not totally identical

popescu-v

See pending comments.

popescu-v

Just a few loose ends, among which a rather important one IMHO.

popescu-v

Just a text to remove (mention of Khiops binaries in the Docker file), and some unused code to remove from the runner (see the pending comments).

…ries only - these packages become mandatory ("khiops-core") or optional ("khiops-driver-*") dependencies dragged during the installation process - these packages must be installed in the Conda environments used to simulate multiple environs (the Conda packages MUST not be used) - in order to avoid distorting usage statistics the test workflows will always use khiops packages from TestPypi - the khiops-server inside the dev docker image will not use any longer the Khiops binaries from the native packages : the `KHIOPS_CMD` and `KHIOPS_COCLUSTERING_CMD` env variables will be set instead

popescu-v

LGTM

tramora marked this pull request as draft May 26, 2026 16:23

tramora force-pushed the core-and-drivers-as-pip-packages branch 9 times, most recently from caa2f18 to fd7c550 Compare May 28, 2026 10:32

tramora marked this pull request as ready for review May 28, 2026 13:44

tramora requested a review from popescu-v May 28, 2026 13:44

tramora force-pushed the core-and-drivers-as-pip-packages branch 2 times, most recently from 394d474 to 5312426 Compare May 28, 2026 21:33

tramora force-pushed the core-and-drivers-as-pip-packages branch from 5312426 to b0223fa Compare May 29, 2026 00:37

tramora force-pushed the core-and-drivers-as-pip-packages branch from 95a1d21 to cfd1802 Compare May 29, 2026 09:43