feat: Add volume and volume mount for service token#60
Open
svenska-primekey wants to merge 1 commit intomainfrom
Open
feat: Add volume and volume mount for service token#60svenska-primekey wants to merge 1 commit intomainfrom
svenska-primekey wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Hey @svenska-primekey thank you for your contribution here. I'm working on a 2.5 release that will include additional features to the issuer. I'll review this and will likely include it in the 2.5 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
values.yaml:42-50Added configuration options:
serviceAccount.automountServiceAccountToken: false(default)serviceAccount.projectedTokenVolume.expirationSeconds: 3607serviceAccount.projectedTokenVolume.defaultMode: 0444serviceaccount.yaml:15Added
automountServiceAccountTokenfield that respects the values.yaml settingdeployment.yaml:31-40Added conditional projected volume for service account token when
automountServiceAccountTokenis falsedeployment.yaml:70-75Added conditional volumeMount to mount the projected token at the standard location
How It Works
When
serviceAccount.automountServiceAccountTokenis set tofalse:/var/run/secrets/kubernetes.io/serviceaccount(standard location)This approach provides better security by:
automountServiceAccountToken: falsesecurity requirement