Skip to content

Fix: invalidver opt-in auto-open #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wimberton wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: invalidver opt-in auto-open #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a5cf07
fix: make invalidver auto-open behavior opt-in via autoOpenDownloadUr…
Wimberton Mar 9, 2026
4c1484c
fix: store descriptive error in response.message on invalidver
Wimberton Mar 9, 2026
ee588ee
The invalidver behavior is now controlled by the autoOpenDownloadUrl …
Wimberton Mar 9, 2026
3224586
rename autoOpenDownloadUrl to auto_open_download_url for snake-case c…
Wimberton Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions auth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,16 +597,24 @@ void KeyAuth::api::init()
else if (json[(XorStr("message"))] == XorStr("invalidver"))
{
std::string dl = json[(XorStr("download"))];
api::app_data.downloadLink = json[XorStr("download")];
if (dl == "")
{
MessageBoxA(0, XorStr("Version in the loader does match the one on the dashboard, and the download link on dashboard is blank.\n\nTo fix this, either fix the loader so it matches the version on the dashboard. Or if you intended for it to have different versions, update the download link on dashboard so it will auto-update correctly.").c_str(), NULL, MB_ICONERROR);
api::app_data.downloadLink = dl;
if (auto_open_download_url) {
if (dl.empty()) {
MessageBoxA(0, XorStr("Version in the loader does not match the one on the dashboard, and the download link on dashboard is blank.\n\nTo fix this, either fix the loader so it matches the version on the dashboard. Or if you intended for it to have different versions, update the download link on dashboard so it will auto-update correctly.").c_str(), NULL, MB_ICONERROR);
}
else {
ShellExecuteA(0, XorStr("open").c_str(), dl.c_str(), 0, 0, SW_SHOWNORMAL);
}
LI_FN(exit)(0);
}
else
{
ShellExecuteA(0, XorStr("open").c_str(), dl.c_str(), 0, 0, SW_SHOWNORMAL);
else {
if (dl.empty()) {
api::response.message = XorStr("Version in the loader does not match the one on the dashboard, and the download link on dashboard is blank. To fix this, either fix the loader so it matches the version on the dashboard. Or if you intended for it to have different versions, update the download link on dashboard so it will auto-update correctly.");
}
else {
api::response.message = XorStr("invalidver");
}
}
LI_FN(exit)(0);
}
}
else {
Expand Down
1 change: 1 addition & 0 deletions auth.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ namespace KeyAuth {
bool block_proxy = false;
bool block_custom_ca = false;
bool block_private_dns = false;
bool auto_open_download_url = true;
static std::string expiry_remaining(const std::string& expiry);
static constexpr const char* kSavePath = "test.json";
static constexpr int kInitFailSleepMs = 1500;
Expand Down