fix(ci): make the consumer canary runnable#96
Merged
Merged
Conversation
Its first real run failed on both jobs: the example .bpf.o objects are gitignored build outputs, so a fresh checkout has no artifact to validate. Caught by dispatching the lane rather than by review. The source-build job now runs 'make examples' (its dependency set already includes the toolchain). The prebuilt job instead drops the artifact entirely and validates in command mode, which needs no compiler at all -- building the fixture there would have pulled in the toolchain that job exists to prove is unnecessary. It still exercises the whole consumer path: resolve the pin to a release, download and checksum the assets, boot, execute in-guest, report. Signed-off-by: ErenAri <erenari27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary's first real dispatch failed on both jobs — the example
.bpf.oobjects are gitignored build outputs, so a fresh checkout has nothing to validate. Found by dispatching the lane, not by review, which is the canary earning its keep on day one (against itself, admittedly).make examples; its dependency set already includes the toolchain.