Clarify default nbf validation behavior in documentation - #533
Open
tatianahub wants to merge 1 commit into
Open
Conversation
Clarify default nbf validation behavior in documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the documentation around
nbfvalidation behavior.While reading the README, I understood that
nbfis automatically validated whenever it is present. However, after checking theValidationdefaults, I found thatnbfvalidation is disabled by default (validate_nbf = false).This update makes the documentation explicit:
expis validated by default.nbfvalidation is supported but must be enabled explicitly.This avoids possible confusion for users relying on the default
Validationconfiguration.