feat: add ES512 algorithm support using P-521 elliptic curve - #532
feat: add ES512 algorithm support using P-521 elliptic curve#532arsenin-kitsoft wants to merge 4 commits into
Conversation
|
|
| // P-521 (ES512) has no `sign_recoverable()` support in RustCrypto, so it can't | ||
| // go through the `define_ecdsa_signer!` macro used for ES256/ES384. |
There was a problem hiding this comment.
Why not adjust the macro? We just discard the recovery ID do we not?
|
@arckoor Eeh, there's a dep mess with P* 0.14 and not only with the 521 one 🤔 |
|
Yeah, the |
|
Had to bump getrandom to 0.4 as well to clear the wasm tests. |
|
@atezet didn't work for me, unfortunately - still breaks with dep clash. |
|
RustCrypto/RSA#647 rsa 0.10 release track |
|
That's very unfortunate. I can still fully review this if you'd like, or we can pick it up once all the dependencies are sorted out |
|
@arckoor I've addressed the issues with tests and with macros that you've highlighted above. But I think it's better to wait for the next release of RSA. |
|
I briefly looked at it and if I'm not mistaken there's a dependency clash on |
Suggested changes for #250
Replacement for #478 with updated dependencies.