Fix recent file menu; fix #3898#3909
Open
wadoon wants to merge 1 commit into
Open
Conversation
wadoon
force-pushed
the
weigl/rcfiles
branch
3 times, most recently
from
019e387 to
affa3d6
Compare
unp1
requested changes
Jul 10, 2026
unp1
left a comment
unp1
left a comment
Member
There was a problem hiding this comment.
Thanks. Just a few minor issues. The problem with tmp is not a blocker just sth to be aware of.
|
|
||
| // if file not present, and it was stored in the tmp folder, | ||
| // we allow us to silently ignore it. | ||
| if (e.path.startsWith(tmpFolder) && !Files.exists(Paths.get(e.path))) { |
Member
There was a problem hiding this comment.
Breaks RecentFileMenuTest (#3711): @TempDir sits under java.io.tmpdir and the test never creates A.key/B.key on disk, so both match the guard and are skipped and getMostRecent() returns null (CI stays red).
One problem tobe aware with java.io.tmpdir is that it is unreliable under macOS /var is a symlink to /private/var, so java.io.tmpdir reads as /var/folders/… while the same file, once canonicalized, is /private/var/folders/…
wadoon
force-pushed
the
weigl/rcfiles
branch
2 times, most recently
from
b1e7b41 to
30b58f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3898
Intended Change
Type of pull request
Ensuring quality