fix(python): match multi_word_search solution arg with starter code#488
Merged
Merged
Conversation
Contributor
Author
|
@jplotts Please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The starter code template for
multi_word_searchin the "Strings and Dictionaries" exercise notebook (notebooks/python/raw/ex_6.ipynb) defines the function signature as:def multi_word_search(doc_list, keywords):However, the official solution in
learntools/python/solns/multi_word_search.pydefines it usingdocumentsas the first argument name:def multi_word_search(documents, keywords):This mismatch (using
documentsinstead ofdoc_listin the solution) causes consistency issues and can lead toNameErrorfor learners who try to adapt their starter code using the solution's body.This PR updates the solution to use
doc_listto match the starter code and maintain consistency with Question 2 (word_search), which also usesdoc_list.