Skip to content

fix(python): match multi_word_search solution arg with starter code#488

Merged
jplotts merged 1 commit into
Kaggle:masterfrom
benluo-maui:fix-multi-word-search-arg
Jun 15, 2026
Merged

fix(python): match multi_word_search solution arg with starter code#488
jplotts merged 1 commit into
Kaggle:masterfrom
benluo-maui:fix-multi-word-search-arg

Conversation

@benluo-maui

Copy link
Copy Markdown
Contributor

The starter code template for multi_word_search in the "Strings and Dictionaries" exercise notebook (notebooks/python/raw/ex_6.ipynb) defines the function signature as:
def multi_word_search(doc_list, keywords):

However, the official solution in learntools/python/solns/multi_word_search.py defines it using documents as the first argument name:
def multi_word_search(documents, keywords):

This mismatch (using documents instead of doc_list in the solution) causes consistency issues and can lead to NameError for learners who try to adapt their starter code using the solution's body.

This PR updates the solution to use doc_list to match the starter code and maintain consistency with Question 2 (word_search), which also uses doc_list.

@benluo-maui

Copy link
Copy Markdown
Contributor Author

@jplotts Please take a look.

@jplotts jplotts self-requested a review June 15, 2026 19:26

@jplotts jplotts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jplotts jplotts merged commit 8a8d445 into Kaggle:master Jun 15, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants