fix(retry): restore jitter in _calculate_backoff_delay#1025
Open
sridipbasu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a jitter calculation bug in
_calculate_backoff_delaythat causedretry back-off jitter to always evaluate to zero, making retries fully
deterministic instead of randomized.
Root Cause
Before (broken)
random() - 0.5produces values in the range[-0.5, 0.5). Applyingint()before scaling truncates every possible value to0, causingthe jitter term to always evaluate to zero.
After (correct)
Applying
int()after the full expression preserves randomized jitterwhile still returning an integer millisecond delay.