Complete engine config select UI revamp by jackwrichards · Pull Request #355 · KSP-RO/RealFuels

jackwrichards · 2026-02-09T07:49:07Z

Engine config UI overhaul

This PR is a full revamp of the engine configuration selector.

Previously this was just a flat list of configs where you had to hover around, eyeball differences, and dig through other menus to understand what you were actually picking. A lot of important data either wasn’t visible or wasn’t even accessible from this screen.

What’s new

Table-based config view

Replaced the old list with a proper table so all configs can be compared side by side
No more hovering or drilling into sub-menus just to see differences
Columns are fully customizable
Supports both Compact and Full views
Adds several new columns that weren’t previously available from this UI at all

Probability and reliability explained

Added a new “Survival Probability vs Burn Time” section at the bottom
Shows ignition chance and survival probability over time in a clear graph
Makes it obvious what rated vs tested burn time actually means
You can see the probability for any burn duration, not just fixed presets

Built-in simulation tools

UI now explains how reliability data is gained and how engines can fail
Interactive slider lets you simulate any amount of accumulated data
Supports engine clusters so you don’t have to do probability math in your head or on paper anymore

Clear risk messaging

Shows a big, simple “1 in X rated burns will fail” readout
Makes the actual risk explicit instead of something players have to guess at

2026-02-08.23-46-07.mp4

…nality - Updated localization string for current engine configuration to be more concise. - Refactored DrawConfigSelectors method to utilize BuildConfigRows for better structure and clarity in the engine configuration UI. - Enhanced the configuration row definition structure for better data handling and display. - Implemented dynamic column width calculation for the configuration table to improve layout adaptability. - Adjusted GUI styles for the editor panel to enhance visual consistency and usability.

- Implemented GetCurrentFlightData method to retrieve the current flight data for a part. - Implemented GetMaximumData method to retrieve the maximum data value for a part. - Added GetDataPercentage method to calculate the percentage of current data relative to maximum data. - Enhanced reflection logic to safely access TestFlightCore methods.

…ta columns and update visibility logic

… into a dedicated UI folder

…roving tooltip styles

RealFuels/RF_TestFlight_UISupport.cfg

periodically-makes-puns · 2026-02-11T07:07:11Z

Some other issues, which I think are unrelated to the patch bug?

If multiple engines have their UIs open at the same time, z-fighting starts occurring. I don't have a great video of this, but it can be fairly easily reproduced by opening and pinning two different engines, and selecting Show GUI on both of them.
The config entry cost appears to consider unlock credit. I personally find it more useful to ignore unlock credit and show the entry cost directly - otherwise it just shows up as Buy (0) for most configs and that's not really useful when picking between engines/configs.

jackwrichards · 2026-02-11T20:09:58Z

Some other issues, which I think are unrelated to the patch bug?

If multiple engines have their UIs open at the same time, z-fighting starts occurring. I don't have a great video of this, but it can be fairly easily reproduced by opening and pinning two different engines, and selecting Show GUI on both of them.

The config entry cost appears to consider unlock credit. I personally find it more useful to ignore unlock credit and show the entry cost directly - otherwise it just shows up as Buy (0) for most configs and that's not really useful when picking between engines/configs.

The first issue, I will look into, I will probably end up making it so only one may be open at a time.
As for the second issue, I agrtee with you, but I have been getting mixed feedback on that.

…Slider Controls - Set default view to compact mode in EngineConfigGUI. - Introduced slider for burn time with input field and include ignition toggle. - Updated survival probability calculations based on slider time in EngineConfigGUI. - Modified reliability section to display survival probabilities for starting, current, and max data units. - Improved layout and styling for survival probability display in EngineConfigInfoPanel. - Refactored simulation controls to include new slider and checkbox for ignition. - Removed redundant failure rate summary section from EngineConfigInfoPanel.

…ng engine config processing

jackwrichards · 2026-02-12T05:50:54Z

Latest look of the UI

siimav · 2026-02-17T20:57:37Z

Source/Engines/EngineConfigPropellants.cs

+    /// </summary>
+    public static class EngineConfigPropellants
+    {
+        private static readonly FieldInfo MRCSConsumedResources = typeof(ModuleRCS).GetField("consumedResources", BindingFlags.NonPublic | BindingFlags.Instance);


Why reflection when GetConsumedResources() exists?

siimav · 2026-02-17T21:18:25Z

Source/Engines/ModuleEngineConfigs.cs

+        public static bool userClosedWindow = false;
+
+        // Track the currently open GUI to ensure only one is visible at a time
+        private static ModuleEngineConfigsBase currentlyOpenGUI = null;


This should get unassigned on leaving editor scene to prevent a :smol: leak

siimav · 2026-02-17T21:38:21Z

Source/Engines/UI/EngineConfigGUI.cs

+            string[] headers = {
+                "Name", Localizer.GetStringByTag("#RF_EngineRF_Thrust"), "Min%",
+                Localizer.GetStringByTag("#RF_Engine_Isp"), Localizer.GetStringByTag("#RF_Engine_Enginemass"),
+                Localizer.GetStringByTag("#RF_Engine_TLTInfo_Gimbal"), Localizer.GetStringByTag("#RF_EngineRF_Ignitions"),
+                Localizer.GetStringByTag("#RF_Engine_ullage"), Localizer.GetStringByTag("#RF_Engine_pressureFed"),
+                "Rated (s)", "Tested (s)", "Ign Reliability", "Burn No Data", "Burn Max Data",
+                "Survival @ Time",
+                Localizer.GetStringByTag("#RF_Engine_Requires"), "Extra Cost", ""
+            };
+            string[] tooltips = {
+                "Configuration name", "Rated thrust", "Minimum throttle",
+                "Sea level and vacuum Isp", "Engine mass", "Gimbal range", "Ignitions",
+                "Ullage requirement", "Pressure-fed", "Rated burn time",
+                "Tested burn time (real-world test duration)",
+                "Ignition reliability (starting / max data)",
+                "Cycle reliability at 0 data", "Cycle reliability at max data",
+                "Survival probability at slider time (starting / max data)",
+                "Required technology", "Extra cost for this config", "Switch and purchase actions"
+            };


Should move all the rest to loc file too. Weird if some are there and others aren't.

siimav · 2026-02-17T21:41:11Z

Source/Engines/UI/EngineConfigGUI.cs

+            int visibleRows = Mathf.Min(actualRows, ConfigMaxVisibleRows);
+            int scrollViewHeight = visibleRows * ConfigRowHeight;
+
+            var scrollStyle = new GUIStyle(GUI.skin.scrollView) { padding = new RectOffset(0, 0, 0, 0) };


Unwise to allocate new styles twice per frame.

siimav · 2026-02-17T21:52:41Z

Source/Engines/UI/EngineConfigGUI.cs

+        internal string GetTechString(ConfigNode node)
+        {
+            if (!node.HasValue("techRequired"))
+                return "-";
+
+            string tech = node.GetValue("techRequired");
+            if (ModuleEngineConfigsBase.techNameToTitle.TryGetValue(tech, out string title))
+                tech = title;
+
+            var words = tech.Split(' ');
+            if (words.Length <= 1)
+                return tech;
+
+            var abbreviated = words[0];
+            for (int i = 1; i < words.Length; i++)
+            {
+                if (words[i].Length > 4)
+                    abbreviated += "-" + words[i].Substring(0, 4);
+                else
+                    abbreviated += "-" + words[i];
+            }
+            return abbreviated;
+        }


Never mind about allocating gui styles. This is a lot worse!
I wonder if we could show only the year number here. Or perhaps just make the text smaller? Make it wrap?

siimav · 2026-02-17T22:02:05Z

Source/Engines/UI/EngineConfigGUI.cs

+
+        #endregion
+
+        #region RP-1 Credit Integration


Should extract such integrations into a separate file.

siimav · 2026-02-17T22:05:12Z

Source/Engines/UI/EngineConfigInfoPanel.cs

+            string[] failureTypes = { "Shutdown", "Perf. Loss", "Reduced Thrust", "Explode" };
+            int[] failureDu = { 1000, 800, 700, 1000 };
+            float[] failurePercents = { 55.2f, 27.6f, 13.8f, 3.4f };


Probably not the best to hardcode all the TF values. Some of those might be subject to change.

periodically-makes-puns · 2026-02-19T21:07:54Z

The configuration menu sometimes doesn't show up when selecting parts with symmetry. It's a bit weird to reproduce but you should run into it fairly quickly if you try reconfiguring a set of RCS thrusters and a cluster of engines a bunch. I suspect it has something to do with how the Hide GUI toggle is handled across symmetric parts.

jackwrichards added 10 commits February 6, 2026 23:20

Implement feature X to enhance user experience and optimize performance

783732c

Implement feature X to enhance user experience and fix bug Y in module Z

70d25b3

Refactor column management in ModuleEngineConfigs to remove unused da…

6c3ea71

…ta columns and update visibility logic

Refactor code structure

252c276

Even more reorganization of the engine config UI code.

4b0952f

Reorganize engine config UI code structure by moving UI-related files…

9ff0dd2

… into a dedicated UI folder

Enhance engine configuration UI by adding close functionality and imp…

9393ec0

…roving tooltip styles

MM Patch fix, and other fixes

52be443

periodically-makes-puns reviewed Feb 11, 2026

View reviewed changes

RealFuels/RF_TestFlight_UISupport.cfg Outdated Show resolved Hide resolved

periodically-makes-puns reviewed Feb 11, 2026

View reviewed changes

RealFuels/RF_TestFlight_UISupport.cfg Outdated Show resolved Hide resolved

jackwrichards added 2 commits February 11, 2026 21:34

refactor: Simplify TestFlight UI support configuration by consolidati…

c55e242

…ng engine config processing

siimav requested changes Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Complete engine config select UI revamp#355

Complete engine config select UI revamp#355
jackwrichards wants to merge 12 commits intoKSP-RO:masterfrom
jackwrichards:master

jackwrichards commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

periodically-makes-puns commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 12, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

siimav Feb 17, 2026

Uh oh!

periodically-makes-puns commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

jackwrichards commented Feb 9, 2026

Engine config UI overhaul

What’s new

Uh oh!

Uh oh!

Uh oh!

periodically-makes-puns commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 11, 2026

Uh oh!

jackwrichards commented Feb 12, 2026

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

siimav Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

periodically-makes-puns commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants