fix(BundleFile): preserve UnityFS flags when saving #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary - Keep UnityFS "none" save flags aligned with UnityFS expectations. - Ensure block_info_flag only carries compression bits. - Mask block flags written into block info. ## Changes - Use `0x40, 0` for UnityFS none save. - Cast and mask `data_flag` / `block_info_flag`. - Mask `block_flag` when writing block info. ## Rationale These changes preserve bundle structure flags and prevent invalid block flags that can make saved bundles fail to load on subsequent reads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
0x40, 0for UnityFS none save.data_flag/block_info_flag.block_flagwhen writing block info.Rationale
These changes preserve bundle structure flags and prevent invalid block flags that can make saved bundles fail to load on subsequent reads.