Fix UnityFS block info flags when saving bundles #355
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Saving UnityFS bundles with UnityPy could produce corrupted block info metadata. In some cases (e.g., Unity 2019.3.x),
UnityPy wrote header-only flags into block info entries. This could cause block info size/parsing mismatches on reload
and lead to struct.error during BundleFile.read_fs().
Root cause:
save() passed block_info_flag=64 for the “none” packer, and save_fs() used that flag directly for block info entries.
The 0x40 bit is a header/layout flag (BlocksAndDirectoryInfoCombined) and should not appear in block info compression
flags. Block info entries should only carry compression-type bits (0x3F).
Changes:
Impact:
Testing: