Skip to content

refactor: [F-6] major refactoring#4

Merged
JustCreature merged 1 commit into
mainfrom
F-6
Feb 19, 2026
Merged

refactor: [F-6] major refactoring#4
JustCreature merged 1 commit into
mainfrom
F-6

Conversation

@JustCreature

Copy link
Copy Markdown
Owner

Refactor: Extract shared components and eliminate code duplication

Extracted 7 reusable components to src/components/common/ and refactored 5 screens to use them, eliminating 400-500 lines of duplicate code.

Changes

  • New components: DialogHeader, EmptyStateDisplay, ConfirmationDialog, EntityContextMenu, LensSelector, ApertureSelector, ShutterSpeedSelector
  • Updated screens: CameraManagementScreen, LensManagementScreen, FilmRollListScreen, SettingsModal
  • Replaced: window.confirm() calls with ConfirmationDialog, duplicate dialog headers, empty states, and form selectors
  • Fixed: MUI Select accessibility with proper useId() implementation

Testing

✅ All 110 E2E tests pass (5 browsers)

Documentation

  • Updated CLAUDE.md with coding best practices
  • Added feature documentation in docs/features/done_F-6.md

🤖 No breaking changes - all refactoring is internal

@JustCreature JustCreature self-assigned this Feb 17, 2026
@JustCreature JustCreature merged commit eca4ec2 into main Feb 19, 2026
2 checks passed
@JustCreature JustCreature deleted the F-6 branch February 19, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant