Skip to content

[NO-TICKET] fix magic url commit sha #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karsonkalt merged 1 commit into from
Sep 25, 2025
Merged

[NO-TICKET] fix magic url commit sha #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/actions/frontend/runtime/magic_url/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ runs:
echo "github_token=${{ inputs.github_token }}"
echo "migration=${{ inputs.migration_number }}"
echo "magic_url_route=${{ inputs.magic_url_route }}"
echo "github.sha=${{ github.sha }}"
echo "github.event.pull_request.head.sha=${{ github.event.pull_request.head.sha }}"
- name: configure_aws_credentials
uses: aws-actions/configure-aws-credentials@v4
with:
Expand All @@ -41,13 +43,10 @@ runs:
# This bucket file location is static and editing it will break the Magic URL. This pushes the entire directory which includes the bundle and remote types if applicable
run: |
aws s3 sync deploy/dist s3://apps.dev.jupiterone.io/static/manual-deploy/${{ github.event.repository.name }}@${{ inputs.migration_number }}/PR-${{ inputs.pr_number }}/
- name: get_branch_of_pr
id: get_branch_of_pr
uses: xt0rted/pull-request-comment-branch@v2
- name: show_magic_url_in_pr
uses: myrotvorets/set-commit-status-action@v2.0.0
with:
sha: ${{ steps.get_branch_of_pr.outputs.head_sha }}
sha: ${{ github.sha }}
token: ${{ inputs.github_token }}
status: success
context: 'Magic URL'
Expand Down