Add optional workspace for allocation-free CHOLMOD solves#727
Open
lorenzogambichler wants to merge 2 commits into
Open
Add optional workspace for allocation-free CHOLMOD solves#727lorenzogambichler wants to merge 2 commits into
lorenzogambichler wants to merge 2 commits into
Conversation
…s cholmod_dense_struct wrappers and Y/E buffers so cholmod_solve2 reuses them across calls instead of reallocating
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
- Coverage 84.39% 84.34% -0.06%
==========================================
Files 13 13
Lines 9371 9413 +42
==========================================
+ Hits 7909 7939 +30
- Misses 1462 1474 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The failed win x86/x64 nightly checks seem to be a dependency resolution fail, so unrelated to this PR from what I can tell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #726
Adds optional preallocated workspace, so repeated solves against fixed sparse Cholesky factorization can reuse internal CHOLMOD cholmod_solve2 Y and E buffers. This eliminates any julia-sided allocations per solve (should reduce to 16 bytes total, as tested). The default solve path remains unchanged, since the workspace is fully optional. I am open to any alternative approaches or suggestions.
API:
Also added a testset similar to that of standard ldiv! above it with appropriate changes.