Skip to content

Comments

add hess for RegularizedNLPModels#87

Merged
MaxenceGollier merged 2 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:hess
Feb 20, 2026
Merged

add hess for RegularizedNLPModels#87
MaxenceGollier merged 2 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:hess

Conversation

@MaxenceGollier
Copy link
Collaborator

Related: #81

Copilot AI review requested due to automatic review settings February 18, 2026 20:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds hess method implementations for AbstractRegularizedNLPModel types to complement the existing hess_op method. The changes enable specialized subtypes (like the L2PenalizedProblem mentioned in the related PR #81) to dispatch custom Hessian implementations while maintaining consistent API behavior.

Changes:

  • Added two hess method overloads that forward to the underlying smooth model, following the same pattern as the existing hess_op method
  • Both methods only compute the Hessian of the smooth objective component, correctly handling the nonsmooth regularizer which doesn't have a classical Hessian
Comments suppressed due to low confidence (1)

src/types.jl:76

  • Extra blank line. The codebase consistently uses single blank lines between function definitions and sections. Please remove one of the blank lines.
  if field == :name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.78%. Comparing base (85de184) to head (8b8379a).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/types.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
- Coverage   99.18%   76.78%   -22.40%     
===========================================
  Files          11       19        +8     
  Lines         369      461       +92     
===========================================
- Hits          366      354       -12     
- Misses          3      107      +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxenceGollier MaxenceGollier merged commit 1fc898e into JuliaSmoothOptimizers:main Feb 20, 2026
11 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the hess branch February 20, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant