Update breakage: use organization-wide workflow#367
Merged
tmigot merged 2 commits intoMay 26, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR centralizes the “Breakage” CI logic by delegating to reusable workflows and adds a follow-up workflow to comment results after the Breakage run completes.
Changes:
- Replace the in-repo Breakage implementation with a reusable workflow call.
- Add a
workflow_run-triggered workflow to post PR comments after Breakage completes. - Remove the local
.breakageJulia helper script and its dedicated Project.toml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/Breakage.yml | Simplifies Breakage to a reusable workflow invocation and narrows PR event types. |
| .github/workflows/CommentBreakage.yml | Adds a workflow that runs on Breakage completion and delegates commenting to a shared workflow. |
| .breakage/get_jso_users.jl | Removes the previous dependency-discovery script (no longer used by the workflow here). |
| .breakage/Project.toml | Removes the Project for the now-deleted breakage helper script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: thollander/actions-comment-pull-request@v2 | ||
| with: | ||
| filePath: breakage/summary.md | ||
| breakage: |
| workflows: ["Breakage"] | ||
| types: | ||
| - completed | ||
|
|
Comment on lines
+4
to
+7
| workflow_run: | ||
| workflows: ["Breakage"] | ||
| types: | ||
| - completed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 89.00% 88.98% -0.02%
==========================================
Files 7 7
Lines 1200 1216 +16
==========================================
+ Hits 1068 1082 +14
- Misses 132 134 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigot
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.