Update breakge: use organization-wide workflow#84
Merged
tmigot merged 2 commits intoMay 26, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR simplifies the repository’s breakage CI by delegating the heavy logic to reusable workflows centrally maintained in JuliaSmoothOptimizers/.github.
Changes:
- Replace the local
Breakageworkflow implementation with a reusable workflow call. - Add a
Comment Breakageworkflow that triggers on completion ofBreakageand delegates PR commenting to a reusable workflow. - Remove the local
.breakageJulia script and its dedicated project dependencies.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/CommentBreakage.yml | New workflow that runs on workflow_run completion and calls a reusable commenting workflow. |
| .github/workflows/Breakage.yml | Replaces the previous multi-job workflow with a reusable workflow call and narrows PR event types. |
| .breakage/get_jso_users.jl | Removed; logic is no longer needed with the centralized workflow. |
| .breakage/Project.toml | Removed; dependencies for the deleted script are no longer needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+9
| breakage: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main No newline at end of file |
Comment on lines
+1
to
+11
| name: Comment Breakage | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Breakage"] | ||
| types: | ||
| - completed | ||
|
|
||
| jobs: | ||
| comment_pr: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main No newline at end of file |
Comment on lines
+10
to
+11
| comment_pr: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main No newline at end of file |
tmigot
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.