Fix multi thread env state in case N=1#968
Open
johannes-fischer wants to merge 1 commit intoJuliaReinforcementLearning:mainfrom
Open
Fix multi thread env state in case N=1#968johannes-fischer wants to merge 1 commit intoJuliaReinforcementLearning:mainfrom
johannes-fischer wants to merge 1 commit intoJuliaReinforcementLearning:mainfrom
Conversation
Member
|
Thanks for catching this! Can you add a test which catches this issue? |
Contributor
Author
|
Is there an environment where the state space is not a |
Member
|
Can you create a minimal custom env extending AbstractEnv? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have come across an issue with
MultiThreadEnvfor an environment where thestate_space(envs[1]=is not aSpace. The error message isERROR: DimensionMismatch: cannot broadcast array to have fewer non-singleton dimensions
because
selectdim(menv.states, N, i)in this case returned a0-dimensional view(::Vector{Vector{Float64}}, 1) with eltype Vector{Float64}.I belief this change should fix the problem.
PR Checklist