Let @validate check ispolyhedral for constraints(_list)#4012
Draft
Let @validate check ispolyhedral for constraints(_list)#4012
@validate check ispolyhedral for constraints(_list)#4012Conversation
schillic
force-pushed
the
schillic/validate_constraints_list
branch
3 times, most recently
from
8167e60 to
562e53b
Compare
schillic
force-pushed
the
schillic/validate_constraints_list
branch
2 times, most recently
from
46161bd to
50ba53d
Compare
schillic
force-pushed
the
schillic/validate_constraints_list
branch
from
50ba53d to
d6580b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have
constraints_listforComplement, which does not actually requireispolyhedral. So we should eitherconstraints_listmethod forComplement(what this PR currently does) orispolyhedralforconstraints_list(i.e., not use this PR).