Skip to content

Let @validate check nonempty set for an_element#3959

Draft
schillic wants to merge 1 commit intomasterfrom
schillic/validate_an_element
Draft

Let @validate check nonempty set for an_element#3959
schillic wants to merge 1 commit intomasterfrom
schillic/validate_an_element

Conversation

@schillic
Copy link
Copy Markdown
Member

@schillic schillic commented Jul 19, 2025

isempty is a heavy check and may crash code that worked before.

@schillic schillic force-pushed the schillic/validate_an_element branch 4 times, most recently from f52856a to 0707635 Compare July 19, 2025 13:13
@schillic schillic marked this pull request as ready for review July 19, 2025 13:37
@schillic schillic added the breaking ❌ This change may break things label Jul 19, 2025
@schillic schillic added the discussion 🗣️ Requires human input label Jul 30, 2025
@schillic schillic force-pushed the schillic/validate_an_element branch from 0707635 to 6522520 Compare August 10, 2025 11:08
@schillic schillic marked this pull request as draft August 17, 2025 21:51
@schillic schillic force-pushed the schillic/validate_an_element branch from 6522520 to 96d9cd5 Compare October 24, 2025 16:38
@schillic schillic force-pushed the schillic/validate_an_element branch from 96d9cd5 to c444cda Compare October 24, 2025 17:10
@schillic schillic changed the title Let validate check nonempty set for an_element Let @validate check nonempty set for an_element Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking ❌ This change may break things discussion 🗣️ Requires human input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant