Load CondaPkg lazily, and drop Pkg as a dependency#752
Open
JamesWrigley wants to merge 2 commits intoJuliaPy:mainfrom
Open
Load CondaPkg lazily, and drop Pkg as a dependency#752JamesWrigley wants to merge 2 commits intoJuliaPy:mainfrom
JamesWrigley wants to merge 2 commits intoJuliaPy:mainfrom
Conversation
This shaves ~0.5s off the load time if `JULIA_PYTHONCALL_EXE` is set.
This removes ~0.4s from the load time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined, these reduce the load time with
JULIA_PYTHONCALL_EXEset from ~1.3s to ~0.3s on my machine.Note that removing Pkg as a dependency could be breaking if packages are depending on accessing Pkg in the juliacall module. But, only
Mainis documented as being available so it is technically ok to remove it in a nonbreaking release: https://juliapy.github.io/PythonCall.jl/stable/juliacall-reference/#Constants