Replace Travis CI with GitHub Actions#85
Open
AJ0070 wants to merge 11 commits intoJuliaParallel:masterfrom
Open
Replace Travis CI with GitHub Actions#85AJ0070 wants to merge 11 commits intoJuliaParallel:masterfrom
AJ0070 wants to merge 11 commits intoJuliaParallel:masterfrom
Conversation
Remove .travis.yml and add .github/workflows/ci.yml. Tests Julia 1 on Linux (x64) and macOS (Apple Silicon), and Julia pre on Linux. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent the default Grid from being garbage collected while distributed matrices or vectors are still alive, matching the pattern already used by DistMatrix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MPICH 5.0 adopted the standard MPI ABI where MPI_Comm changed from int to a pointer type. The pre-compiled Elemental binary is incompatible with this new ABI, causing segfaults in Grid::VCSize(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Elemental binary was linked against libmpi.so.12 (MPICH 3.x). MPICH 4.x may have internal ABI differences despite the same soname. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Elemental binary segfaults on Julia 1.12 in Grid::VCSize() regardless of MPICH version. Adding 1.10 to determine if this is a Julia version compatibility issue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The C interface functions ElDistSparseMatrixCreate and ElDistMultiVecCreate take an ElConstGrid (Grid pointer), not an MPI_Comm. The Julia wrappers were incorrectly passing an ElComm integer which got reinterpret_cast'd as a Grid pointer, causing a null pointer dereference in Grid::VCSize(). Also revert the MPICH_jll version constraint and Julia 1.10 CI entry since those were not the root cause. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ElDistSparseMatrixComm and ElDistMultiVecComm don't exist in the C API. Replace comm(A) calls with A.grid and remove the dead comm functions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@andreasnoack tests are passing now! |
andreasnoack
reviewed
Mar 9, 2026
Member
|
I'm surprised that the last commit causes |
Author
|
I am not sure, currently trying to figure it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove .travis.yml and add .github/workflows/ci.yml. Tests Julia 1 on Linux (x64) and macOS (Apple Silicon), and Julia pre on Linux.
continuing work from #84