Skip to content

Add ASDF format#427

Open
icweaver wants to merge 3 commits intoJuliaIO:masterfrom
icweaver:asdf
Open

Add ASDF format#427
icweaver wants to merge 3 commits intoJuliaIO:masterfrom
icweaver:asdf

Conversation

@icweaver
Copy link
Copy Markdown
Contributor

@icweaver icweaver commented Mar 21, 2026

Hi all, we're hoping to add support for this format which is being positioned as the successor to FITS files in the field of astronomy.

cc: @eschnett

@icweaver
Copy link
Copy Markdown
Contributor Author

Hi all, just wanted to check back in on if there is anything else needed from our end. Thanks!

@SimonDanisch
Copy link
Copy Markdown
Member

Nice! I'm guessing the CI failures aren't your fault?

@icweaver
Copy link
Copy Markdown
Contributor Author

That is my guess, but could be mistaken. Tests past locally, but look to fail on the same tests in CI as other recent PRs here, like for the OGG detection and MATROSKA detection PosixPath tests. I haven't investigated further yet though

@icweaver
Copy link
Copy Markdown
Contributor Author

icweaver commented Apr 4, 2026

Looks like it might be a download issue for some older tests. As a temporary fix, I just added a @test_skip on request errors over in #431 for your review @SimonDanisch

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (822cdad) to head (7796df5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          11       11           
  Lines         713      713           
=======================================
  Hits          652      652           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver
Copy link
Copy Markdown
Contributor Author

icweaver commented Apr 7, 2026

Glad the fix worked alright =]. I think things are looking pretty green on this end now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants