Replace AD testing utilities with DifferentiationInterfaceTest.jl#596
Open
Replace AD testing utilities with DifferentiationInterfaceTest.jl#596
Conversation
Contributor
|
KernelFunctions.jl documentation for PR #596 is available at: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 94.46% 93.50% -0.96%
==========================================
Files 52 52
Lines 1463 1463
==========================================
- Hits 1382 1368 -14
- Misses 81 95 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theogf
reviewed
Mar 14, 2026
Member
theogf
left a comment
theogf
left a comment
There was a problem hiding this comment.
Since the diff is pretty big I might be missing something but I see you delete the tests for the kernels but don't really replace them? Is that correct?
Member
Author
|
Yeah the perf ones I decided to drop. The others have been replaced in testutils. |
Member
Author
|
Strange that the 1.6 tests are still listed. |
Member
|
No just checked |
simsurace
force-pushed
the
diff-interface-test
branch
from
0325190 to
fa88cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We update the AD testing infrastructure to better deal with new/changing backends.
Proposed changes
We replace all AD test utils with DifferentiationInterfaceTest.jl calls. We remove some tests for allocations that have been flaky in the past.
What alternatives have you considered?
None.
Breaking changes
None.