**BREAKING**: Migrate from Requires.jl to package extensions#591
**BREAKING**: Migrate from Requires.jl to package extensions#591
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 94.47% 94.46% -0.02%
==========================================
Files 52 52
Lines 1466 1463 -3
==========================================
- Hits 1385 1382 -3
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simsurace
force-pushed
the
replace-requires
branch
from
c86de48 to
8358f79
Compare
theogf
left a comment
theogf
left a comment
There was a problem hiding this comment.
Looks good! Could you also update the docs in https://juliagaussianprocesses.github.io/KernelFunctions.jl/dev/api/#Conditional-Utilities ?
Project.toml
Outdated
| Kronecker = "0.4, 0.5" | ||
| LogExpFunctions = "0.2.1, 0.3" | ||
| Requires = "1.0.1" | ||
| PDMats = "0.9, 0.10, 0.11" |
There was a problem hiding this comment.
I am not certain that all version of PDMats are supported?
There was a problem hiding this comment.
I'm also not. Happy to require 0.11
What is there to update? The user experience does not change, does it? |
simsurace
force-pushed
the
replace-requires
branch
from
8358f79 to
009b396
Compare
|
Huh, not sure why Julia 1.6 tests are scheduled at all. |
Just to mention that it is using extensions. So maybe just mention https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) and add that one just needs to have loaded for this to worl |
|
We'll ignore the Zygote failures, I'll address them in a separate PR. |
We drop 1.6 support while we are at it. The minimum to support package extensions would be 1.9, but we will support LTS.
simsurace
force-pushed
the
replace-requires
branch
from
dd2e56c to
2902bc9
Compare
2 participants
Summary
We replace Requires.jl to conditionally load code dependent on PDMats.jl and Kronecker.jl by package extensions. This requires Julia 1.9. We support Julia LTS (currently 1.10) only. This was discussed in #585.
What alternatives have you considered?
None.
Breaking changes
Julia <1.10 is no longer supported.