Add printf support by charleskawczynski · Pull Request #163 · JuliaGPU/KernelAbstractions.jl

charleskawczynski · 2020-12-21T16:21:38Z

This is my first pass at adding printf support. I'm still experimenting, but I may need help with this!

simonbyrne · 2020-12-22T04:15:37Z

+        # @sprintf($sfmt, $(args...))
+        @print(@sprintf($sfmt, $(args...)))
+        # @print("test")


Suggested change

# @sprintf($sfmt, $(args...))

@print(@sprintf($sfmt, $(args...)))

# @print("test")

@printf($sfmt, $(args...))

?

This results in a StackOverflowError

Maybe it should be Base.@printf?

Ah, yes. Needed Printf.@printf

Co-authored-by: Simon Byrne <simonbyrne@gmail.com>

DilumAluthge · 2021-01-06T05:47:50Z

Let's see if CI passes.

bors try

bors · 2021-01-06T05:51:06Z

try

Build failed:

buildkite/kernelabstractions-dot-jl/julia-1-dot-5

DilumAluthge · 2021-01-06T05:53:07Z

CI fails with: (link to CI log)

�[37mprint test: �[39m�[91m�[1mError During Test�[22m�[39m at �[39m�[1m/var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:35�[22m
  Got exception outside of a @test
  InvalidIRError: compiling kernel gpu_kernel_printf(Cassette.Context{nametype(CUDACtx),KernelAbstractions.CompilerMetadata{DynamicSize,DynamicCheck,Nothing,CartesianIndices{1,Tuple{Base.OneTo{Int64}}},NDRange{1,DynamicSize,StaticSize{(4,)},CartesianIndices{1,Tuple{Base.OneTo{Int64}}},Nothing}},Nothing,KernelAbstractions.var"##PassType#253",Nothing,Cassette.DisableHooks}, typeof(gpu_kernel_printf)) resulted in invalid LLVM IR
  Reason: unsupported dynamic function invocation (call to _cuprintf(::Val{fmt}, argspec...) where fmt in CUDA at /root/.julia/packages/CUDA/YeS8q/src/device/intrinsics/output.jl:38)
  Stacktrace:
   [1] overdub at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/src/backends/cuda.jl:327
   [2] macro expansion at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:21
   [3] gpu_kernel_printf at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/src/macros.jl:80
   [4] overdub at /root/.julia/packages/Cassette/158rp/src/overdub.jl:0
  Reason: unsupported dynamic function invocation (call to _cuprintf(::Val{fmt}, argspec...) where fmt in CUDA at /root/.julia/packages/CUDA/YeS8q/src/device/intrinsics/output.jl:38)
  Stacktrace:
   [1] overdub at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/src/backends/cuda.jl:327
   [2] macro expansion at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:22
   [3] gpu_kernel_printf at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/src/macros.jl:80
   [4] overdub at /root/.julia/packages/Cassette/158rp/src/overdub.jl:0
  Stacktrace:
   [1] check_ir(::GPUCompiler.CompilerJob{GPUCompiler.PTXCompilerTarget,CUDA.CUDACompilerParams}, ::LLVM.Module) at /root/.julia/packages/GPUCompiler/uTpNx/src/validation.jl:123
   [2] macro expansion at /root/.julia/packages/GPUCompiler/uTpNx/src/driver.jl:239 [inlined]
   [3] macro expansion at /root/.julia/packages/TimerOutputs/ZmKD7/src/TimerOutput.jl:206 [inlined]
   [4] codegen(::Symbol, ::GPUCompiler.CompilerJob; libraries::Bool, deferred_codegen::Bool, optimize::Bool, strip::Bool, validate::Bool, only_entry::Bool) at /root/.julia/packages/GPUCompiler/uTpNx/src/driver.jl:237
   [5] compile(::Symbol, ::GPUCompiler.CompilerJob; libraries::Bool, deferred_codegen::Bool, optimize::Bool, strip::Bool, validate::Bool, only_entry::Bool) at /root/.julia/packages/GPUCompiler/uTpNx/src/driver.jl:39
   [6] compile at /root/.julia/packages/GPUCompiler/uTpNx/src/driver.jl:35 [inlined]
   [7] cufunction_compile(::GPUCompiler.FunctionSpec; kwargs::Base.Iterators.Pairs{Symbol,Int64,Tuple{Symbol},NamedTuple{(:maxthreads,),Tuple{Int64}}}) at /root/.julia/packages/CUDA/YeS8q/src/compiler/execution.jl:310
   [8] check_cache(::Dict{UInt64,Any}, ::Any, ::Any, ::GPUCompiler.FunctionSpec{typeof(Cassette.overdub),Tuple{Cassette.Context{nametype(CUDACtx),KernelAbstractions.CompilerMetadata{DynamicSize,DynamicCheck,Nothing,CartesianIndices{1,Tuple{Base.OneTo{Int64}}},NDRange{1,DynamicSize,StaticSize{(4,)},CartesianIndices{1,Tuple{Base.OneTo{Int64}}},Nothing}},Nothing,KernelAbstractions.var"##PassType#253",Nothing,Cassette.DisableHooks},typeof(gpu_kernel_printf)}}, ::UInt64; kwargs::Base.Iterators.Pairs{Symbol,Int64,Tuple{Symbol},NamedTuple{(:maxthreads,),Tuple{Int64}}}) at /root/.julia/packages/GPUCompiler/uTpNx/src/cache.jl:40
   [9] gpu_kernel_printf at ./none:0 [inlined]
   [10] cufunction(::typeof(Cassette.overdub), ::Type{Tuple{Cassette.Context{nametype(CUDACtx),KernelAbstractions.CompilerMetadata{DynamicSize,DynamicCheck,Nothing,CartesianIndices{1,Tuple{Base.OneTo{Int64}}},NDRange{1,DynamicSize,StaticSize{(4,)},CartesianIndices{1,Tuple{Base.OneTo{Int64}}},Nothing}},Nothing,KernelAbstractions.var"##PassType#253",Nothing,Cassette.DisableHooks},typeof(gpu_kernel_printf)}}; name::String, kwargs::Base.Iterators.Pairs{Symbol,Int64,Tuple{Symbol},NamedTuple{(:maxthreads,),Tuple{Int64}}}) at /root/.julia/packages/CUDA/YeS8q/src/compiler/execution.jl:297
   [11] macro expansion at /root/.julia/packages/CUDA/YeS8q/src/compiler/execution.jl:109 [inlined]
   [12] (::KernelAbstractions.Kernel{CUDADevice,StaticSize{(4,)},DynamicSize,typeof(gpu_kernel_printf)})(; ndrange::Tuple{Int64}, dependencies::Nothing, workgroupsize::Nothing, progress::Function) at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/src/backends/cuda.jl:187
   [13] test_printf(::CUDADevice) at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:32
   [14] top-level scope at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:45
   [15] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1115
   [16] top-level scope at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/print_test.jl:36
   [17] include(::String) at ./client.jl:457
   [18] top-level scope at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/runtests.jl:33
   [19] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/Test.jl:1115
   [20] top-level scope at /var/lib/buildkite-agent/builds/rtx2070-gpuci1-julia-csail-mit-edu/julialang/kernelabstractions-dot-jl/test/runtests.jl:33
   [21] include(::String) at ./client.jl:457
   [22] top-level scope at none:6
   [23] eval(::Module, ::Any) at ./boot.jl:331
   [24] exec_options(::Base.JLOptions) at ./client.jl:272
   [25] _start() at ./client.jl:506

Add printf support

ca79220

simonbyrne reviewed Dec 21, 2020

View reviewed changes

Comment thread src/KernelAbstractions.jl Outdated

simonbyrne reviewed Dec 22, 2020

View reviewed changes

Update src/KernelAbstractions.jl

4a3acad

Co-authored-by: Simon Byrne <simonbyrne@gmail.com>

charleskawczynski force-pushed the ck/printf branch from fe34241 to 4a3acad Compare January 4, 2021 20:05

bors Bot added a commit that referenced this pull request Jan 6, 2021

Try #163:

3784d67

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add printf support#163

Add printf support#163
charleskawczynski wants to merge 2 commits intoJuliaGPU:mainfrom
charleskawczynski:ck/printf

charleskawczynski commented Dec 21, 2020

Uh oh!

Uh oh!

simonbyrne Dec 22, 2020

Uh oh!

charleskawczynski Dec 24, 2020

Uh oh!

simonbyrne Jan 4, 2021

Uh oh!

charleskawczynski Jan 4, 2021

Uh oh!

DilumAluthge commented Jan 6, 2021

Uh oh!

bors Bot commented Jan 6, 2021

Uh oh!

DilumAluthge commented Jan 6, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

charleskawczynski commented Dec 21, 2020

Uh oh!

Uh oh!

simonbyrne Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

charleskawczynski Dec 24, 2020

Choose a reason for hiding this comment

Uh oh!

simonbyrne Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

charleskawczynski Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

DilumAluthge commented Jan 6, 2021

Uh oh!

bors Bot commented Jan 6, 2021

try

Uh oh!

DilumAluthge commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DilumAluthge commented Jan 6, 2021 •

edited

Loading