Provide more robustness for some lowering differences#144
Merged
Conversation
This allows some variants for struct lowering, in particular using the `declare_` intrinsic rather than `=` and allowing an assignment around `typebody!`. This was developed with JuliaLang/julia#60569. This may or may not be needed in the final version of that PR, but it's good for this code to be less brittle there regardless since those are reasonable lowerings.
Core.declare_global only exists on Julia nightly (the typegroup branch). Without this guard, accessing Core.declare_global throws UndefVarError on Julia 1.10/1.12/release, matching the existing pattern used by is_declare_const. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Feb 21, 2026
Provides fixes that go with JuliaLang/julia#60569 and JuliaLang/julia#61036 Also needs JuliaDebug/LoweredCodeUtils.jl#144
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Feb 21, 2026
Provides fixes that go with JuliaLang/julia#60569 and JuliaLang/julia#61036 Also needs JuliaDebug/LoweredCodeUtils.jl#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows some variants for struct lowering, in particular using the
declare_intrinsic rather than=and allowing an assignment aroundtypebody!.This was developed with JuliaLang/julia#60569. This may or may not be needed in the final version of that PR, but it's good for this code to be less brittle there regardless since those are reasonable lowerings.