fix: datetime tryparse (#265)#267
Conversation
|
Yup no need to add specific tests. This should be added to the ZonedDateTime and UTCDateTime parsing methods as well though, to replicate the same behaviour (I assume it also happens for those types?). For ZonedDateTime you can put the whole for-loop in the try-catch. |
|
Well, in the end, I moved all
Also, I've updated I am using |
|
Well, in the end, I moved all
Also, I've updated I am using |
|
Sorry for bothering @iamed2 , but is there anything else that should be done in this PR? |
I've tested it locally with Julia versions 1.7.2 and 1.8.1 and it works correctly. Not sure, whether it make sense to add any specific tests, since
runtestsworks with postgres database as a whole and should cover this function (for latest versions of Julia at least).