added: stochastic state defects as linear equality constraints for all CollocationMethods#335
Open
franckgaga wants to merge 19 commits intomainfrom
Open
added: stochastic state defects as linear equality constraints for all CollocationMethods#335franckgaga wants to merge 19 commits intomainfrom
CollocationMethods#335franckgaga wants to merge 19 commits intomainfrom
Conversation
It is never used, since the same as `Aeq` matrix, and it cause confusion with the linear defect constraint of `CollocationMethod`s
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 98.58% 98.59%
=======================================
Files 27 27
Lines 5176 5189 +13
=======================================
+ Hits 5103 5116 +13
Misses 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
To avoid confusion with the matrix related to the stochastic model (lowercase "s") It's not easy avoiding greek letters for matrix and vector 🫠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect of the stochastic state are now treated as linear equality constraint for all
CollocationMethods.Let's benchmark the differences. It it proves substantial, I can also implement the same thing for
MultipleShootingandNonLinModel. Let's see.