remove dependancy on internal base func

[rokke-git]

it doesn't seem like it even changes anything, just calls an expensive invoke for some reason? I don't know what this was trying to do but I'll fix it if it breaks anything somehow; trying to clean up these internal array print functions in base and found your package complaining that "print_matrix_row not defined in Base" when importing a downstream package

edit: ok, I think I'm starting to see what this is trying to do. prob should have started at block arrays as mentioned in the comment...

[dlfivefifty]

But coverage is 100%? How is it that it can't be called?

As the comment makes clear, this is to support downstream BlockArrays.jl

[rokke-git]

sorry, like I was saying in my edit; I was going too fast. it does get called; but when looking at code only in your repo it just sends execution back down the normal display pipeline. this section should maybe be in ext, and axes_print_matrix_row should maybe be explicitly imported from BlockArrays, but I think it works as is. I'm looking at the block arrays side of this first, that's why I marked as draft to come back here after I look at that side

wow, just realized you can run the origin's ci workflows from pull requests on your own fork...

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (4e42293) to head (167bbd8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   99.91%   99.91%   -0.01%     
==========================================
  Files           9        9              
  Lines        1234     1232       -2     
==========================================
- Hits         1233     1231       -2     
  Misses          1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.