test: improve render coverage from 7.8% to 18.6%#34
Merged
JordanCoin merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Adds targeted unit tests in codemap/render to increase coverage of rendering helpers (tree/skyline/depgraph) without changing production code.
Changes:
- Adds table-driven tests for
titleCase,getSystemName,filterCodeFiles,aggregateByExtension, andgetBuildingChar. - Adds tests for
createBuildingslayout/label trimming andDepgraphempty-source output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+435
to
+438
| t.Run("drops buildings until layout fits width budget", func(t *testing.T) { | ||
| rng = rand.New(rand.NewPCG(42, 0)) | ||
| sorted := []extAgg{ | ||
| {ext: ".go", size: 1000, count: 1}, |
There was a problem hiding this comment.
Same global-state issue here: the subtest overwrites the package-level rng without restoring it. Consider using old := rng; rng = ...; t.Cleanup(func(){ rng = old }) to keep tests isolated.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderhelper logic inrender/tree_test.gotitleCase,getSystemName,filterCodeFiles,aggregateByExtension,getBuildingChar,createBuildings, and empty-sourceDepgraphCoverage
Validation
go test -race -coverprofile=coverage.out ./...go vet ./...gofmt -l .Coverage Floor
Current CI floor in
.github/workflows/ci.ymlismin=30.0.Total coverage increase is
+2.1points, so floor was not bumped (requires+5).