Skip to content

test(generator): add coverage for exact SVG dimensions per size parameter#894

Open
Subhooo5 wants to merge 1 commit into
JhaSourav07:mainfrom
Subhooo5:test/svg-dimensions-per-size
Open

test(generator): add coverage for exact SVG dimensions per size parameter#894
Subhooo5 wants to merge 1 commit into
JhaSourav07:mainfrom
Subhooo5:test/svg-dimensions-per-size

Conversation

@Subhooo5
Copy link
Copy Markdown
Contributor

Description

Fixes #723

  • Added focused generator test coverage to verify exact SVG width and height values for small, medium, and large size presets.
  • Removed the unused escapeXML import from app/api/streak/route.ts to resolve the npm run lint warning and keep the CI/lint pipeline clean.

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 28, 2026

@Subhooo5 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Subhooo5
Copy link
Copy Markdown
Contributor Author

Hey @JhaSourav07 Desired test successfully added. All existing tests pass locally. Feel free to review, add necessary labels and merge it. 🫂🚀

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Subhooo5 Two clean changes: removes unused escapeXML import (lint fix), adds 3 dimension tests verifying exact SVG sizes for small/medium/large

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(svg generator): verify medium size produces exactly 600×420 SVG dimensions

2 participants