Add artifact exclusion and goal mode orchestration logic - #201
Open
mashan555 wants to merge 6 commits into
Open
Conversation
…t with comprehensive tests
Contributor
|
Address the identified logic and naming concerns to improve the robustness and clarity of the new artifact exclusion utility. Comments
Help us improve Junie code review (EAP): Share feedback |
Comment on lines
+94
to
+96
| // Keep whatever the checkout already excluded and append below it. | ||
| const prefix = existing === "" || existing.endsWith("\n") ? existing : `${existing}\n`; | ||
| fs.writeFileSync(excludePath, `${prefix}${EXCLUDE_HEADER}\n${missing.join("\n")}\n`); |
Contributor
There was a problem hiding this comment.
Suggested change
| // Keep whatever the checkout already excluded and append below it. | |
| const prefix = existing === "" || existing.endsWith("\n") ? existing : `${existing}\n`; | |
| fs.writeFileSync(excludePath, `${prefix}${EXCLUDE_HEADER}\n${missing.join("\n")}\n`); | |
| // Keep whatever the checkout already excluded and append below it. | |
| const prefix = existing === "" || existing.endsWith("\n") ? existing : `${existing}\n`; | |
| const header = existing.includes(EXCLUDE_HEADER) ? "" : `${EXCLUDE_HEADER}\n`; | |
| fs.writeFileSync(excludePath, `${prefix}${header}${missing.join("\n")}\n`); |
Check if the header already exists before appending it to avoid duplication when patterns are added incrementally.
Comment on lines
+61
to
+68
| test("does not append a pattern that is only present as a comment", () => { | ||
| fs.mkdirSync(path.dirname(excludePath), {recursive: true}); | ||
| fs.writeFileSync(excludePath, "# .junie/plans/\n"); | ||
|
|
||
| const added = addGitExcludePatterns([".junie/plans/"], repoDir); | ||
|
|
||
| expect(added).toEqual([".junie/plans/"]); | ||
| }); |
Contributor
There was a problem hiding this comment.
The test name is misleading. It should indicate that the pattern is appended even if present as a comment, as the expectation expect(added).toEqual([".junie/plans/"]) confirms.
mashan555
force-pushed
the
fadeeva/goal-in-action
branch
2 times, most recently
from
August 11, 2026 10:48
7c029e6 to
3388487
Compare
mashan555
force-pushed
the
fadeeva/goal-in-action
branch
from
August 11, 2026 12:13
3388487 to
ecb313a
Compare
mashan555
force-pushed
the
fadeeva/goal-in-action
branch
from
August 11, 2026 12:33
20c2d27 to
b3cba92
Compare
…e PR and commit titles, updated workflows, and expanded regex handling logic with tests
…ed PR title resolution and agent artifact exclusion logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.