Open
Conversation
added 30 commits
September 30, 2023 12:10
added 23 commits
March 6, 2024 11:02
cbravo135
reviewed
May 16, 2024
Collaborator
cbravo135
left a comment
cbravo135
left a comment
There was a problem hiding this comment.
One minor request: Please change the name of SimPartProcessor to SimPartAnaProcessor since this is a run mode 1 processor that runs on a hpstr ntuple. We call these kinds of Processors AnaProcessors so it is clear what run mode you need hpstr in for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.