Rory cluster

[rodwyer100]

The most recent version of SvtRawDataAnaProcessor I was using. Furthermore the new Cluster processors

[sarahgaiser]

I will give this a second round of review once you are done cleaning up your code. Please remove all old/unused print statements and functions that are commented out and no longer needed. It would be great if you could also document your code. That means including a short statement about the purpose of a function or class, input and output of the function and general nice-to-know things about it. For classes, you usually also add short comments about the class attributes.
If you want to have a reference for including comments, you can refer to this.

[rodwyer100]

Okay I changed the names to names Cam suggested, though I had to get a little creative as he already created a processor called 'TrackHitAnaProcessor" which I didn't know about. One is now called "TrackHitCompareAnaProcessor" while the other is "SVTClusterAnaProcessor" as it would have had the already used name; both of these were approved names for the object by Cam. I addressed the double usage of the for loop indexer and verified that it did not affect the operation of the processor as expected; I changed it anyways as it is confusing and potentially dangerous. I also addressed the hardcoded location of bad channels by putting it into a dat collection and I believe thats everything so far :)!

[sarahgaiser]

I have updated the formatting of your code. Can you check if everything builds and if the output is as expected? Once you got that done, I'll approve.

[rodwyer100]

I got it so it compiles and does what it should do. Had to add some changes from RawSvtHitHistos.cxx in analysis to do it, but they ought to be minor.

[sarahgaiser]

Looks good to me now!

[cbravo135]

Remove scripts/AddIdentity.C

[cbravo135]

Remove this file, such an identifier already exists in the event header.

[rodwyer100]

This identifier is used to identify separate reconstruction techniques. Is that in the event header?

[cbravo135]

you could easily do what you want with the existing header, yes

[cbravo135]

You just have to fill it correctly

[cbravo135]

This file should be somewhere in analysis, not processors.

[rodwyer100]

Done, put in analysis/data