You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are my comments for coding:
Basically, the updates are for application of 2016 DAQ configuration in the new digitization system.
So Similar updates can be taken as PR#1019 for the updates for application of 2016 DAQ configuration.
For EcalDigitizationWithPulserDataMergingReadout2016Driver.java, do not need to add this new driver. Instead, you can update EcalDigitizationWithPulserDataMergingReadoutDriver.java. Refer to driver for how to do updates.
For the new steering file, since DAQ configuration is applied, parameters for digitization and trigger system are loaded from the DAQ configuration and they are run dependent, so do not set them in the steering file. Refer to steering file
Looks fine for me. But validation is needed before approval.
Keep one thing in mind:
According to experience of 2019&2021, peak for delta_time between track and cluster might change due to the new readout system. So <trackClusterTimeOffset>36.8</trackClusterTimeOffset> in reconstruction steering files might need to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.