Nsj BadHit class

[nsjarvis]

There are some known evio format problems in the data from the f250, f125 and dirc. This PR introduces a new class DBadHit to contain the roc and slot info when one of these errors is found. There is a plugin and a macro to make a plot of the roc and slot, if errors are found. When it creates a BadHit it writes a message to jerr.

For the f125 it only logs a bad hit if the number of peaks is 1, to suppress the apparent errors occurring when that number has been recorded erroneously (usually few-bit errors, it appears as 9, 17, 25), as the CDC and FDC settings require (and always required) data for only 1 peak per hit.

It deals nicely with issues like 703

It does not do anything for the data errors affecting the swap_bank function.

The intention is to use the plugin for online monitoring, so that problematic rocs can be rebooted when needed.

The picture is was generated using the bad_hits plugin with 133245 file 0.

[gluex]

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/log

Build log: /work/halld/pull_request_test/halld_recon^nsj_badhit/make_nsj_badhit.log
Build report: /work/halld/pull_request_test/halld_recon^nsj_badhit/report_nsj_badhit.txt
Location of build: /work/halld/pull_request_test/halld_recon^nsj_badhit

[gluex]

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_recon^nsj_badhit/make_nsj_badhit.log
Build report: /work/halld/pull_request_test/halld_recon^nsj_badhit/report_nsj_badhit.txt
Location of build: /work/halld/pull_request_test/halld_recon^nsj_badhit

[nsjarvis]

I reverted the cleanup of JEventSource_EVIO.* because it is still used in these old and obscure plugins. 😜 Mea Culpa, I should have done a grep -r instead of just recompiling.

Utilities/evio_writer
Utilities/merge_rawevents
monitoring/DAQ_online
monitoring/EVNT_online
monitoring/pedestal_online

and also listed in libraries/CMakeLists.txt   

[gluex]

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/log

Build log: /work/halld/pull_request_test/halld_recon^nsj_badhit/make_nsj_badhit.log
Build report: /work/halld/pull_request_test/halld_recon^nsj_badhit/report_nsj_badhit.txt
Location of build: /work/halld/pull_request_test/halld_recon^nsj_badhit

[nsjarvis]

Examples:
hd_rawdata_133245_000.evio (DIRC/SSP)
hd_rawdata_101622_001.evio (fa250)
I haven't found an example for the helicity board.

I have not tried to fix any event decoding problems. I might try that in a separate PR.

[gluex]

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_recon^nsj_badhit/tests/log

Build log: /work/halld/pull_request_test/halld_recon^nsj_badhit/make_nsj_badhit.log
Build report: /work/halld/pull_request_test/halld_recon^nsj_badhit/report_nsj_badhit.txt
Location of build: /work/halld/pull_request_test/halld_recon^nsj_badhit

[aaust]

Great addition to the monitoring tools