Skip to content

Commit 88d8e57

Browse files
committed
summary fix
1 parent 4b9171c commit 88d8e57

1 file changed

Lines changed: 19 additions & 13 deletions

File tree

.github/workflows/docker.yml

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -103,14 +103,25 @@ jobs:
103103

104104

105105
- name: Summarize image reference
106-
if: ${{ always() }}
106+
shell: bash
107107
env:
108108
IMAGE: ${{ needs.discover.outputs.image }}
109109
TAG: ${{ matrix.geant4_tag }}-${{ matrix.docker_from }}
110110
PUSHED: ${{ github.event_name != 'pull_request' }}
111111
IS_ARCH: ${{ startsWith(matrix.docker_from, 'archlinux:') }}
112112
run: |
113+
# prepare summary target safely
114+
if [ -n "${GITHUB_STEP_SUMMARY:-}" ]; then
115+
mkdir -p "$(dirname "$GITHUB_STEP_SUMMARY")"
116+
SUMMARY_OUT="$GITHUB_STEP_SUMMARY"
117+
else
118+
SUMMARY_OUT="$RUNNER_TEMP/step_summary.md"
119+
mkdir -p "$(dirname "$SUMMARY_OUT")"
120+
echo "GITHUB_STEP_SUMMARY not set; writing to $SUMMARY_OUT"
121+
fi
122+
113123
PLATFORM_HINT="--platform=linux/amd64"
124+
114125
{
115126
echo "## Docker Image"
116127
echo ""
@@ -142,19 +153,18 @@ jobs:
142153

143154
echo ""
144155
echo "### Run with browser (noVNC)"
145-
echo "This container exposes a VNC-over-WebSocket UI on port **6080**. After starting, open **http://localhost:6080** in your browser."
156+
echo "Open **http://localhost:6080** after starting."
146157
echo ""
147158
echo "**Default geometry:** \`1280x800\` (override with \`-e GEOMETRY=WIDTHxHEIGHT\`)."
148159
echo ""
149-
echo '**Start (Linux/Windows, same host arch):**'
160+
echo '**Start (same-arch host):**'
150161
echo '```bash'
151162
if [ "$IS_ARCH" = "true" ]; then
152163
echo "docker run --rm -p 6080:6080 ${PLATFORM_HINT} ${IMAGE}:${TAG}"
153164
else
154165
echo "docker run --rm -p 6080:6080 ${IMAGE}:${TAG}"
155166
fi
156167
echo '```'
157-
158168
echo ""
159169
echo '**Start with custom resolution:**'
160170
echo '```bash'
@@ -165,14 +175,10 @@ jobs:
165175
fi
166176
echo '```'
167177

168-
echo ""
169-
echo '**Start on Apple Silicon (Mac, Arch image is amd64-only):**'
170-
echo '```bash'
171-
echo "docker run --rm -p 6080:6080 ${PLATFORM_HINT} ${IMAGE}:${TAG}"
172-
echo '```'
173-
174178
echo ""
175179
echo "### Notes by distro"
176-
echo "- **Ubuntu/Debian/Fedora/AlmaLinux**: container launches **Xvfb + x11vnc + noVNC**; browse to http://localhost:6080."
177-
echo "- **Arch Linux**: container launches **Xvfb + x0vncserver (TigerVNC) + noVNC**; image is amd64-only → use \`${PLATFORM_HINT}\` on arm64 hosts."
178-
} >> \"$GITHUB_STEP_SUMMARY\"
180+
echo "- **Ubuntu/Debian/Fedora/AlmaLinux**: Xvfb + x11vnc + packaged noVNC."
181+
echo "- **Arch Linux**: Xvfb + x0vncserver (TigerVNC) + noVNC from /opt (amd64-only → use \`${PLATFORM_HINT}\` on arm64)."
182+
} >> "$SUMMARY_OUT"
183+
184+
echo "Summary written to: $SUMMARY_OUT"

0 commit comments

Comments
 (0)