@@ -103,15 +103,6 @@ def unique_preserve_order(items):
103103 return out
104104
105105
106- def debian_adjustments (pkgs : list [str ]) -> list [str ]:
107- rep = {
108- "libqt6opengl6t64" : "libqt6opengl6" ,
109- "libqt6openglwidgets6t64" : "libqt6openglwidgets6" ,
110- "libmysqlclient-dev" : "libmariadb-dev"
111- }
112- return [rep .get (p , p ) for p in pkgs ]
113-
114-
115106cleanup_string_by_family = {
116107 "fedora" : (
117108 " \\ \n && dnf -y update"
@@ -209,9 +200,9 @@ def packages_to_be_installed(distro: str) -> str:
209200
210201def install_root_tarball (base : str , local_setup_file : str ) -> str :
211202 root_version = "6.36.04"
212- if base == " ubuntu" :
213- os_name = "ubuntu24.04-x86_64-gcc13.3"
214- elif base == "debian" :
203+ # ubuntu
204+ os_name = "ubuntu24.04-x86_64-gcc13.3"
205+ if base == "debian" :
215206 os_name = "debian12-x86_64-gcc12.2" # adjust to an actual ROOT build name if available
216207 root_file = f'root_v{ root_version } .Linux-{ os_name } .tar.gz'
217208 root_remote_file = f'https://root.cern/download/{ root_file } '
@@ -290,13 +281,15 @@ def packages_install_commands(image: str, base: str) -> str:
290281 " && dnf config-manager --set-enabled crb \\ \n "
291282 " && dnf install -y almalinux-release-synergy \n \n "
292283 )
284+ commands += "# Install Packages\n "
293285 commands += f"RUN dnf install -y --allowerasing { packages } { cleanup } "
294286
295287 elif family == "ubuntu" :
296288 commands += "RUN apt-get update\n \n "
297289 commands += "# Install CA tools\n "
298290 commands += "RUN apt-get install -y ca-certificates\n "
299291 commands += "RUN update-ca-certificates\n \n "
292+ commands += "# Install Packages\n "
300293 commands += (
301294 "RUN ln -fs /usr/share/zoneinfo/America/New_York /etc/localtime \\ \n "
302295 " && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends tzdata "
@@ -305,13 +298,14 @@ def packages_install_commands(image: str, base: str) -> str:
305298 commands += install_root_tarball (image , local_setup_file )
306299
307300 elif family == "archlinux" :
308- commands += f"RUN pacman -Sy --noconfirm archlinux-keyring\n "
301+ commands += f"RUN pacman -Sy --noconfirm archlinux-keyring\n \n "
302+ commands += "# Install Packages\n "
309303 commands += f"RUN pacman -Syu --noconfirm --needed { packages } { cleanup } "
310304 # Install noVNC from upstream for Arch
311305 commands += install_novnc_for_arch ()
312306
313307 commands += install_meson ()
314- commands += novnc_launch_commands (novnc_launch_commands )
308+ commands += novnc_launch_commands (image )
315309 return commands
316310
317311
0 commit comments