Fix bug with crash when doing large allocations#2
Open
bglaessle wants to merge 1 commit intoJeffersonLab:masterfrom
Open
Fix bug with crash when doing large allocations#2bglaessle wants to merge 1 commit intoJeffersonLab:masterfrom
bglaessle wants to merge 1 commit intoJeffersonLab:masterfrom
Conversation
While trying to run a chroma job with a very large local volume I got a crash due to allocation failure. I tracked this down and the error comes from integer overflow. Using a normal int instead of size_t for holding the size of an allocation is not the best idea. This commit changes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A chroma job with a very large local volume produces an allocation failure crash, due
to an integer overflow.