Skip to content

feat(webui): toggle detail panel by re-clicking the active card#39

Merged
JaredforReal merged 1 commit into
mainfrom
feat/toggle-envelope-detail
May 7, 2026
Merged

feat(webui): toggle detail panel by re-clicking the active card#39
JaredforReal merged 1 commit into
mainfrom
feat/toggle-envelope-detail

Conversation

@jimpablo
Copy link
Copy Markdown
Collaborator

@jimpablo jimpablo commented May 6, 2026

Summary

  • Clicking an already-selected envelope card now closes the detail panel instead of keeping it open
  • Widens onSelect prop type from (id: string) to (id: string | null) in Column and KanbanBoard

Test plan

  • Click an envelope card → detail panel opens
  • Click the same card again → detail panel closes
  • Click a different card while one is open → switches to new card's detail
  • X button still closes the panel as before

Signed-off-by: jimpablo <194239734+jimpablo@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 6, 2026 09:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WebUI inbox interaction so that clicking the currently-selected envelope card toggles the detail panel closed, making selection behavior more consistent with a “toggle” interaction pattern.

Changes:

  • Allow onSelect to receive null in KanbanBoard and Column prop types so selection can be cleared via the same callback.
  • Implement “re-click active card to close” by toggling selection to null when the clicked card is already active.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
loom/webui/frontend/src/components/KanbanBoard.tsx Widens onSelect prop typing to accept null to support clearing the selection.
loom/webui/frontend/src/components/Column.tsx Updates onSelect typing and toggles selection off when clicking the active EnvelopeCard.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JaredforReal JaredforReal merged commit f8ba769 into main May 7, 2026
7 checks passed
@jimpablo jimpablo deleted the feat/toggle-envelope-detail branch May 7, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants