feat(webui): toggle detail panel by re-clicking the active card#39
Merged
Conversation
Signed-off-by: jimpablo <194239734+jimpablo@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the WebUI inbox interaction so that clicking the currently-selected envelope card toggles the detail panel closed, making selection behavior more consistent with a “toggle” interaction pattern.
Changes:
- Allow
onSelectto receivenullinKanbanBoardandColumnprop types so selection can be cleared via the same callback. - Implement “re-click active card to close” by toggling selection to
nullwhen the clicked card is already active.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
loom/webui/frontend/src/components/KanbanBoard.tsx |
Widens onSelect prop typing to accept null to support clearing the selection. |
loom/webui/frontend/src/components/Column.tsx |
Updates onSelect typing and toggles selection off when clicking the active EnvelopeCard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onSelectprop type from(id: string)to(id: string | null)inColumnandKanbanBoardTest plan