zarrv3 w/ sharding fusion bug fixes#58
Merged
indecisiveuser merged 0 commit intoJaneliaSciComp:zarrv3from Mar 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
With the new additions in multiview-reconstruction, please call InterestPointsN5.saveInterestPointsStatic() for as much as possible in the parallel run
Contributor
There was a problem hiding this comment.
No no no :) Let's fix the main issue in multiview-reconstruction. Saving calls XmlIOSpimData2.saveInterestPointsInParallel() which should be fine, however it does open a new N5Writer for each correspondence and interest point save. Let's fix it there, specifically in InterestPointsN5.saveCorrespondencesStatic() and saveInterestPointsStatic(), may be complicated by the fact that is has a super class. Let's discuss ...
Collaborator
Author
|
Note that this has not yet been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— fixes block parsing when using sharding
— updates naming of mvrecon split_views to SplitDistributeEvenly
— ensures that fusion downsampling jobs on spark are retried