Skip to content

Update privacy-policy.html - #17

Open
Siedlerchr wants to merge 2 commits into
mainfrom
privacy-policy
Open

Update privacy-policy.html#17
Siedlerchr wants to merge 2 commits into
mainfrom
privacy-policy

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

No description provided.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Replace privacy policy with concise DSGVO Art. 13 notice

📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Replaces the full 2021 privacy policy with a shorter Art. 13 DSGVO notice.
• Updates controller/contact details and documents GitHub hosting/logfile retention.
• Adds member-management processing description and a condensed list of data-subject rights.
Diagram

graph TD
A["Site visitor"] --> B["JabRef website"] --> C["assets/privacy-policy.html"]
C --> D["Privacy notice content"]
C --> E["References: GitHub hosting"]
C --> F["Generated via Stiftung Datenschutz"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Keep the comprehensive policy and update sections incrementally
  • ➕ Lower legal coverage risk by preserving previously documented processing activities
  • ➕ Easier to compare deltas and ensure nothing required was dropped
  • ➖ Long and harder to maintain
  • ➖ May contain outdated vendor/processing details that require more ongoing work
2. Host privacy text in Markdown and generate HTML during site build
  • ➕ Simpler editing/review (diffs are clearer than large HTML blocks)
  • ➕ Can enforce linting/format rules and avoid stray placeholder markup
  • ➖ Requires build/pipeline support for conversion
  • ➖ May not fit current static asset workflow
3. Link to an externally maintained privacy policy page
  • ➕ Single source of truth if multiple properties need the same policy
  • ➕ Updates can be made without redeploying the site
  • ➖ External availability/control risk
  • ➖ Harder to guarantee consistent UX and localization

Recommendation: If the intent is to simplify to a minimal Art. 13 notice, this approach is fine, but ensure the new text is production-ready (e.g., remove placeholder authority '==...==' and any generator-markup artifacts like '++Vorstand++') and confirm that dropping the previously listed processing categories (analytics, social media, payment providers, etc.) is compliant with the site’s actual data processing.

Files changed (1) +34 / -90

Documentation (1) +34 / -90
privacy-policy.htmlReplace full privacy policy with Stiftung Datenschutz Art. 13 notice +34/-90

Replace full privacy policy with Stiftung Datenschutz Art. 13 notice

• Removes the previous long-form (2021) GDPR privacy policy and replaces it with a shorter Art. 13 DSGVO notice. Updates responsible entity/contact info, describes logfile retention and GitHub hosting, adds member-management processing, and provides a condensed list of data-subject rights including a (currently placeholder) supervisory authority reference.

assets/privacy-policy.html

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Aug 13, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Unresolved policy placeholders ✓ Resolved 🐞 Bug ≡ Correctness
Description
assets/privacy-policy.html includes generator/markdown placeholders like ++Vorstand++ and
==...== that will be rendered verbatim on /privacy-policy because the file is injected as raw
HTML via v-html. This ships incomplete/broken-looking legal text to users (including an
unspecified supervisory authority).
Code

assets/privacy-policy.html[31]

+    <li>ein Beschwerderecht bei einer Datenschutz-Aufsichtsbehörde, wenn Sie finden, dass wir Ihre Daten nicht ordnungsgemäß verarbeiten. Für unseren Verein ist ==...== zuständig. Wenn Sie sich in einem anderen Bundesland oder nicht in Deutschland aufhalten, können Sie sich aber auch an die dortige Datenschutzbehörde wenden.</li>
Evidence
The placeholders are present in the updated HTML, and the rendering path imports the file as raw
text and injects it directly into the DOM with v-html, so the markers will not be transformed and
will appear on the live page.

assets/privacy-policy.html[15-32]
pages/privacy-policy.vue[1-6]
components/LegalPage.vue[7-13]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`assets/privacy-policy.html` contains unresolved placeholder/markdown markers (`++...++`, `==...==`) that will be displayed to end users because the page renders the file as raw HTML.
## Issue Context
The privacy policy is imported with `?raw` and rendered using Vue `v-html`, so there is no markdown or placeholder processing step.
## Fix Focus Areas
- assets/privacy-policy.html[15-32]
- pages/privacy-policy.vue[1-6]
- components/LegalPage.vue[7-13]
## Suggested fix
- Replace `++Vorstand++` with proper HTML markup (e.g., `<strong>Vorstand</strong>` or just plain text) and remove any other non-HTML generator markers.
- Replace `==...==` with the actual responsible supervisory authority name (or remove the sentence if it must not be shown).
- Re-read the privacy-policy page after build to ensure no placeholder markers remain in rendered output.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Conflicting page heading ✓ Resolved 🐞 Bug ⚙ Maintainability
Description
The updated privacy-policy content adds its own `, but LegalPage already renders an ` for the
page title, resulting in two page-level headings. This makes heading ownership inconsistent and can
produce a confusing document outline for navigation/audits.
Code

assets/privacy-policy.html[1]

+<h1 id="datenschutzhinweise-gem-art-13-dsgvo">Datenschutzhinweise gemäß Art. 13 DSGVO</h1>
Evidence
LegalPage always outputs an `` and then injects the raw HTML content below; the updated
privacy-policy HTML begins with another ``, so the rendered page will contain both.

components/LegalPage.vue[7-13]
assets/privacy-policy.html[1-4]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`LegalPage` renders a page title as an `<h1>`, but `assets/privacy-policy.html` now also starts with an `<h1>`, causing two page-level headings.
## Issue Context
The legal content is injected into the page via `v-html`, so any headings in the HTML become part of the document structure.
## Fix Focus Areas
- assets/privacy-policy.html[1-5]
- components/LegalPage.vue[7-13]
## Suggested fix
- Preferred: remove the `<h1>` from `assets/privacy-policy.html` and start the embedded document at `<h2>` (or lower) so `LegalPage` remains the single page-level heading.
- Alternative: extend `LegalPage` with an option to suppress its `<h1>` for pages whose content provides the full heading structure.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread assets/privacy-policy.html Outdated
Comment thread assets/privacy-policy.html Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant